Re: C99 compliance for src/port/snprintf.c

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: C99 compliance for src/port/snprintf.c
Date: 2018-08-15 15:56:43
Message-ID: 20180815155643.zx4qpcmpvhemefyg@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

On 2018-Aug-15, Robert Haas wrote:

> On Tue, Aug 14, 2018 at 7:28 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > I'm almost tempted to think that the reasons above make this a
> > back-patchable bug fix. Comments?
>
> No objections to changing the behavior. Have you checked whether
> there are any noticeable performance consequences?
>
> Back-patching seems a bit aggressive to me considering that the danger
> is hypothetical.

That was my first thought too, and my preferred path would be to make
this master-only and only consider a backpatch later if we find some
practical reason to do so.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-08-15 16:01:28 Re: C99 compliance for src/port/snprintf.c
Previous Message Robert Haas 2018-08-15 15:56:20 Re: libpq should append auth failures, not overwrite

Browse pgsql-www by date

  From Date Subject
Next Message Robert Haas 2018-08-15 16:01:28 Re: C99 compliance for src/port/snprintf.c
Previous Message Andres Freund 2018-08-15 15:52:37 Re: C99 compliance for src/port/snprintf.c