Re: Patch to implement pg_current_logfile() function

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: "Karl O(dot) Pinc" <kop(at)meme(dot)com>
Cc: Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to implement pg_current_logfile() function
Date: 2016-11-09 01:51:46
Message-ID: CA+TgmoaZTxQaCB6Wx12fb4Hs4FTNuhTov7Lojmu9AU0nn+t21A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 3, 2016 at 7:34 PM, Karl O. Pinc <kop(at)meme(dot)com> wrote:
> To me, the CURRENT_LOG_FILENAME symbol should contain the name
> of the current log file. It does not. The CURRENT_LOG_FILENAME symbol
> holds the name of the file which itself contains the name of
> the log file(s) being written, plus the log file
> structure of each log file.

I agree that this is confusing.

> IMO, the name of the log files being written, as well as
> the type of data structure written into each log file,
> are meta-information about the logging data. So maybe
> the right name is LOG_METAINFO_DATAFILE.

+1 for something like this.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-11-09 01:53:51 Re: commitfest 2016-11 status summary
Previous Message Daniel Gustafsson 2016-11-09 01:19:01 Re: Radix tree for character conversion