| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: pgsql: Add 'basebackup_to_shell' contrib module. |
| Date: | 2022-03-30 16:42:50 |
| Message-ID: | CA+TgmoaZ6L37kVJPRDavbtRa+wq-vtBkd3L9s=B7d91BF-UW4Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Mar 30, 2022 at 12:30 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> # Reconfigure to restrict access and require a detail.
> $shell_command =
> $PostgreSQL::Test::Utils::windows_os
> ? qq{$gzip --fast > "$escaped_backup_path\\\\%d.%f.gz"}
> : qq{$gzip --fast > "$escaped_backup_path/%d.%f.gz"};
>
> I don't think the branch is needed anymore, forward slashes should work for
> output redirection.
We have similar things in src/test/perl/PostgreSQL/Test/Cluster.pm. Do
you think those can also be removed? I'm not sure it's the place of
this patch to introduce a mix of styles.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-03-30 16:50:39 | Re: pgsql: Add 'basebackup_to_shell' contrib module. |
| Previous Message | Andres Freund | 2022-03-30 16:35:24 | pgsql: ci: enable zstd where available. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-03-30 16:50:39 | Re: pgsql: Add 'basebackup_to_shell' contrib module. |
| Previous Message | Tom Lane | 2022-03-30 16:34:34 | Re: pgsql: Add 'basebackup_to_shell' contrib module. |