Re: Server side lo-funcs name

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Server side lo-funcs name
Date: 2013-06-10 21:58:50
Message-ID: CA+TgmoaN8P2V0xtmGwAC90zpjx4O6ZMge+ErfCxqRz3MmtRGew@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jun 9, 2013 at 8:16 PM, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
> Recently we got a complain about server side large object function
> names described in the doc:
> http://www.postgresql.org/message-id/51B2413F.8010305@gmail.com
>
> In the doc:
> http://www.postgresql.org/docs/9.3/static/lo-funcs.html
>
> "There are server-side functions callable from SQL that correspond to
> each of the client-side functions described above; indeed, for the
> most part the client-side functions are simply interfaces to the
> equivalent server-side functions"
>
> From the description it is hard for users to find out server side
> functions "loread" and "lowrite" becuase they are looking for
> "lo_read" and "lo_write". So I think his complain is fair. Included
> patches attempt to fix the problem.

+ each of the client-side functions described above(please note

This line contains an obvious whitespace error, but more than that, I
think the resulting paragraph doesn't read very well this way. I
would suggest adding a new paragraph further down, maybe like this:

--- a/doc/src/sgml/lobj.sgml
+++ b/doc/src/sgml/lobj.sgml
@@ -572,6 +572,14 @@ SELECT lo_export(image.raster, '/tmp/motd') FROM image
The client-side functions do not require superuser privilege.
</para>

+ <para>
+ The functionality of <function>lo_read</function> and
+ <function>lo_write</function> is also available via server-side calls,
+ but the names of the server-side functions differ from the client side
+ interfaces in that they do not contain underscores. You must call
+ these functions as <function>loread</> and <function>lowrite</>.
+ </para>
+
</sect1>

<sect1 id="lo-examplesect">

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2013-06-10 22:02:48 Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement)
Previous Message Robert Haas 2013-06-10 21:50:34 Re: Batch API for After Triggers