From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Logical WAL sender unresponsive during decoding commit |
Date: | 2022-10-19 23:47:24 |
Message-ID: | CA+TgmoaLObg0QbstbC8ykDwOdD1bDkr4AbPpB=0DPgA2JW0mFg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Aug 23, 2022 at 4:40 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Mon, Aug 22, 2022 at 4:48 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > On Tue, Aug 16, 2022 at 2:37 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > > I've attached patches for all supported branches.
> >
> > LGTM. I'll push this tomorrow unless there are comments/suggestions.
>
> Pushed.
I think this was a good change, but there's at least one other problem
here: within ReorderBufferRestoreChanges, the while (restored <
max_changes_in_memory && *segno <= last_segno) doesn't seem to contain
a CFI. Note that this can loop either by repeatedly failing to open a
file, or by repeatedly reading from a file and passing the data read
to ReorderBufferRestoreChange. So I think there should just be a CFI
at the top of this loop to make sure both cases are covered.
--
Robert Haas
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2022-10-20 00:41:28 | Re: thinko in basic_archive.c |
Previous Message | Corey Huinker | 2022-10-19 23:24:25 | Re: refactor ownercheck and aclcheck functions |