Re: Non-empty default log_line_prefix

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Christoph Berg <myon(at)debian(dot)org>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Non-empty default log_line_prefix
Date: 2016-10-12 18:59:45
Message-ID: CA+TgmoaJBFCmz9669pxuryoOoG=y=YhLVGHRXr6NLYpG-pQ8OA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 12, 2016 at 11:20 AM, Christoph Berg <myon(at)debian(dot)org> wrote:
> Re: Jeff Janes 2016-10-12 <CAMkU=1zmOp5T70MX508nwFf8tvv2jOT+hGwLq8fNHLSxp-wVmQ(at)mail(dot)gmail(dot)com>
>> Do you think the pushback will come from people who just accept the
>> defaults?
>
> I'm concerned about readability. "2016-10-12 20:14:30.449 CEST" is a
> lot of digits. My eyes can parse "20:14:30" as a timestamp, but
> "20:14:30.449" looks more like an IP address. (Admittedly I don't have
> experience with reading %m logs.)
>
> Overall, I'd prefer %t but %m would be ok as well.

I'm fine with either! Both are much better than the empty string.
One of the problems with the status quo is that many users don't even
realize that log_line_prefix exists, so they don't configure it at
all. They don't even realize that they have the option to add a
prefix. I think configuring a non-empty default will be both better
by default and more likely to make people realize that they have
choices.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-10-12 19:02:53 Re: pg_dump getBlobs query broken for 7.3 servers
Previous Message Robert Haas 2016-10-12 18:55:26 Re: Speed up Clog Access by increasing CLOG buffers