Re: Non-empty default log_line_prefix

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Christoph Berg <myon(at)debian(dot)org>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Non-empty default log_line_prefix
Date: 2016-10-12 19:07:32
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

* Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
> On Wed, Oct 12, 2016 at 11:20 AM, Christoph Berg <myon(at)debian(dot)org> wrote:
> > Re: Jeff Janes 2016-10-12 <CAMkU=1zmOp5T70MX508nwFf8tvv2jOT+hGwLq8fNHLSxp-wVmQ(at)mail(dot)gmail(dot)com>
> >> Do you think the pushback will come from people who just accept the
> >> defaults?
> >
> > I'm concerned about readability. "2016-10-12 20:14:30.449 CEST" is a
> > lot of digits. My eyes can parse "20:14:30" as a timestamp, but
> > "20:14:30.449" looks more like an IP address. (Admittedly I don't have
> > experience with reading %m logs.)
> >
> > Overall, I'd prefer %t but %m would be ok as well.
> I'm fine with either! Both are much better than the empty string.
> One of the problems with the status quo is that many users don't even
> realize that log_line_prefix exists, so they don't configure it at
> all. They don't even realize that they have the option to add a
> prefix. I think configuring a non-empty default will be both better
> by default and more likely to make people realize that they have
> choices.

For my 2c, I'd rather have %m, but I definitely agree with Robert that
we need to do *something* here and if the only thing holding us back is
%t vs. %m, then let's just pick one and move on. I'll just hold my nose
when I see the default and change it to %m.



In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-10-12 19:24:27 Re: pg_dump getBlobs query broken for 7.3 servers
Previous Message Devrim Gündüz 2016-10-12 19:05:21 Re: Non-empty default log_line_prefix