| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] path toward faster partition pruning |
| Date: | 2018-02-06 16:36:50 |
| Message-ID: | CA+TgmoaFppRnEKp_zjM3ARkRt3EuQR7NiycYqAyzxhEPOf3dpA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 6, 2018 at 4:55 AM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> I understand why COLLATION_MATCH think that a collation OID match is
>> OK, but why is InvalidOid also OK? Can you add a comment? Maybe some
>> test cases, too?
>
> partcollid == InvalidOid means the partition key is of uncollatable type,
> so further checking the collation is unnecessary.
Yeah, but in that case wouldn't BOTH OIDs be InvalidOid, and thus the
equality test would mach anyway?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-02-06 17:01:08 | Re: Cancelling parallel query leads to segfault |
| Previous Message | Robert Haas | 2018-02-06 16:33:59 | Re: Temporary tables prevent autovacuum, leading to XID wraparound |