Re: [COMMITTERS] pgsql: Centralize definition of integer limits.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Subject: Re: [COMMITTERS] pgsql: Centralize definition of integer limits.
Date: 2015-04-02 15:55:31
Message-ID: CA+TgmoaF8iWGOwM7Guxytxyixwed74dBY0H=ZEMwOudUh-cO7w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Apr 2, 2015 at 11:54 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2015-04-02 10:42:58 -0400, Robert Haas wrote:
>> On Tue, Mar 31, 2015 at 12:15 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> >> > I'm tempted to just prefix our limits with PG_ and define them
>> >> > unconditionally, including appropriate casts to our types.
>> >>
>> >> I don't have a better idea.
>> >
>> > Will push that.
>>
>> I'd appreciate it if you could do this soon. I like to compile with
>> -Werror, and this problem means I can't.
>
> Done. Sorry for not doing this sooner, I'm more or less having holidays
> right now.

Thanks. Sorry to interrupt your vacation.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2015-04-02 15:59:57 pgsql: Add missing calls to DatumGetUInt32.
Previous Message Andres Freund 2015-04-02 15:54:20 Re: [COMMITTERS] pgsql: Centralize definition of integer limits.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-04-02 15:58:09 Re: What exactly is our CRC algorithm?
Previous Message Andres Freund 2015-04-02 15:54:20 Re: [COMMITTERS] pgsql: Centralize definition of integer limits.