Re: [COMMITTERS] pgsql: Centralize definition of integer limits.

From: andres(at)anarazel(dot)de (Andres Freund)
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Subject: Re: [COMMITTERS] pgsql: Centralize definition of integer limits.
Date: 2015-04-02 15:54:20
Message-ID: 20150402155419.GD17586@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2015-04-02 10:42:58 -0400, Robert Haas wrote:
> On Tue, Mar 31, 2015 at 12:15 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> >> > I'm tempted to just prefix our limits with PG_ and define them
> >> > unconditionally, including appropriate casts to our types.
> >>
> >> I don't have a better idea.
> >
> > Will push that.
>
> I'd appreciate it if you could do this soon. I like to compile with
> -Werror, and this problem means I can't.

Done. Sorry for not doing this sooner, I'm more or less having holidays
right now.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2015-04-02 15:55:31 Re: [COMMITTERS] pgsql: Centralize definition of integer limits.
Previous Message Andres Freund 2015-04-02 15:45:56 pgsql: Define integer limits independently from the system definitions.

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-04-02 15:55:31 Re: [COMMITTERS] pgsql: Centralize definition of integer limits.
Previous Message Dean Rasheed 2015-04-02 15:50:26 Re: Tables cannot have INSTEAD OF triggers