| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] static assertions in C++ |
| Date: | 2017-11-29 14:41:15 |
| Message-ID: | CA+TgmoaDQ9wHF0DPCaXDbec8v4eetXy1+3zFiX--kWUuhRBZ4w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 29, 2017 at 9:26 AM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> I'd still like a review of this patch.
I don't think there's much to review apart from this one issue.
Neither Tom nor I seem to be convinced about:
+/* not worth providing a workaround */
I suggested that it was worth providing a workaround, and Tom
suggested that the case might be so rare that we could just #error if
happens. If you agree that it's never likely to come up, I suggest
going with Tom's #error proposal; otherwise, I suggest trying to find
a workable workaround.
Apart from that, the only thing I see is that it seems like the
comment block just before your code changes might need some updating.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Victor Drobny | 2017-11-29 14:56:30 | Re: new function for tsquery creartion |
| Previous Message | Fabien COELHO | 2017-11-29 14:26:51 | Re: PATCH: pgbench - option to build using ppoll() for larger connection counts |