| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] static assertions in C++ |
| Date: | 2017-11-29 18:22:50 |
| Message-ID: | 20171129182250.s6y6gtig5ioibi7i@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-11-29 09:41:15 -0500, Robert Haas wrote:
> On Wed, Nov 29, 2017 at 9:26 AM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> > I'd still like a review of this patch.
>
> I don't think there's much to review apart from this one issue.
> Neither Tom nor I seem to be convinced about:
>
> +/* not worth providing a workaround */
FWIW, I think that's a perfectly reasonable choice. Adding complications
in making static assertions work for random archaic compilers when
compiling with c++ just doesn't seem worth more than a few mins of
thought.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Emre Hasegeli | 2017-11-29 18:28:26 | Re: [HACKERS] [PATCH] Improve geometric types |
| Previous Message | Shubham Barai | 2017-11-29 17:50:36 | Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index |