Re: fairywren is generating bogus BASE_BACKUP commands

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: fairywren is generating bogus BASE_BACKUP commands
Date: 2022-01-24 03:52:14
Message-ID: CA+TgmoaCg6SX8YEnkwQAwDaqk0SSk9x2_EFWRFCLEafFqXroKA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jan 23, 2022 at 4:09 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> The most common issues we get are around this issue of virtualized paths
> in the TAP tests. If people followed the rule I suggested upthread, 99%
> of those problems would go away.

Well, that makes it sound like it's the fault of people for not
following the rules, but I don't think that's really a fair
assessment. Even your first guess as to how to solve this particular
problem wasn't correct, and if you can't guess right on the first try,
I don't know how anyone else is supposed to do it. I still don't even
understand why your first guess wasn't right. I feel like every time I
try to add a TAP test Msys blows up, and I can't figure out how to fix
it myself. Which is not a great feeling.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2022-01-24 03:58:05 Re: [PATCH] Implement INSERT SET syntax
Previous Message Andres Freund 2022-01-24 03:49:57 Re: Replace uses of deprecated Python module distutils.sysconfig