| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
| Date: | 2015-06-26 19:24:29 |
| Message-ID: | CA+Tgmoa66DQy=LYYr7vSVpkUEK79ec-uRC3p3VL+iwwe1KbEgg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Jun 15, 2015 at 2:52 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> Attached patch provides a fix as per above discussion.
I think we should emit some LOG messages here. When we detect the
file is there:
LOG: ignoring tablespace_map file because no backup_label file exists
If the rename fails:
LOG: could not rename file "%s" to "%s": %m
If it works:
LOG: renamed file "%s" to "%s"
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-06-26 19:32:38 | Re: pgsql: release notes: Add entry for commit 5ea86e6e6. |
| Previous Message | Robert Haas | 2015-06-26 18:55:54 | pgsql: release notes: Add entry for commit 5ea86e6e6. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2015-06-26 19:36:53 | Re: Removing SSL renegotiation (Was: Should we back-patch SSL renegotiation fixes?) |
| Previous Message | Robert Haas | 2015-06-26 19:12:00 | Re: pg_rewind failure by file deletion in source server |