| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2022-01-21 18:33:15 |
| Message-ID: | CA+Tgmoa-ST7fMLsVJduOB7Eub=2WjfpHS+QxHVEpUoinf4bOSg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 19, 2022 at 4:26 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I spent some time thinking about test coverage for the server-side
> backup code today and came up with the attached (v12-0003).
I committed the base backup target patch yesterday, and today I
updated the remaining code in light of Michael Paquier's commit
5c649fe153367cdab278738ee4aebbfd158e0546. Here is the resulting patch.
Michael, I am proposing to that we remove this message as part of this commit:
- pg_log_info("no value specified for compression
level, switching to default");
I think most people won't want to specify a compression level, so
emitting a message when they don't seems too verbose.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v13-0001-Server-side-gzip-compression.patch | application/octet-stream | 33.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-01-21 18:34:31 | Re: New developer papercut - Makefile references INSTALL |
| Previous Message | Tomas Vondra | 2022-01-21 18:31:38 | Re: document the need to analyze partitioned tables |