From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pg_basebackup ignores the existing data directory permissions |
Date: | 2019-03-18 15:45:05 |
Message-ID: | CA+TgmoZw78qVNaGF-CGdQ4=g48G_LtxNWqQK5MNa_J51Z2W9Qw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Mar 18, 2019 at 11:36 AM Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 2019-03-18 14:47, Robert Haas wrote:
> >> Based on the feedback gathered, having a separate option to enforce
> >> the default and not touching the behavior implemented until now,
> >> sounds fine to me.
> > That's not what I'm proposing. I think the behavior implemented until
> > now is not best, because the files within the directory should inherit
> > the directory's permissions, not the remote side's permissions.
>
> I'm strongly in favor of keeping initdb and pg_basebackup options
> similar and consistent. They are both ways to initialize data directories.
>
> You'll note that initdb does not behave the way you describe. It's not
> unreasonable behavior, but it's not the way it currently works.
So you want to default to no group access regardless of the directory
permissions, with an option to enable group access that must be
explicitly specified? That seems like a reasonable option to me; note
that initdb does seem to chdir() an existing directory.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2019-03-18 15:47:26 | Re: Add exclusive backup deprecation notes to documentation |
Previous Message | Peter Eisentraut | 2019-03-18 15:35:56 | Re: pg_basebackup ignores the existing data directory permissions |