Re: pgsql: Clarify use of temporary tables within partition trees

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Clarify use of temporary tables within partition trees
Date: 2018-07-03 01:07:58
Message-ID: CA+TgmoZsw_dYH3RWEfvCoR=OwbFEn+H3c+-wp8MWerQWoY61iQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Jul 2, 2018 at 8:59 PM, David Rowley
<david(dot)rowley(at)2ndquadrant(dot)com> wrote:
>> How would you formulate it? Perhaps the error message did not emphasize
>> enough on the fast that it actually blocked a behavior, say "Block mix
>> of temporary and permanent relations in partition trees" or such?

Yes.

> For me, reading the subject line of the commit I'd have expected a doc
> change, or improved/new code comments.
>
> This is really more "Disallow mixed temp/permanent partitioned hierarchies".

Yes.

> "Clarify" does not really involve a change of behaviour. It's an
> explanation of what the behaviour is.

And yes.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-07-03 04:55:02 Re: pgsql: Clarify use of temporary tables within partition trees
Previous Message David Rowley 2018-07-03 00:59:33 Re: pgsql: Clarify use of temporary tables within partition trees

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-07-03 01:16:50 Re: automatic restore point
Previous Message Yotsunaga, Naoki 2018-07-03 01:07:41 RE: automatic restore point