Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version.
Date: 2017-09-05 16:29:41
Message-ID: CA+TgmoZpe2YJdFLFH6YSka5TVX4VcsmT05cEXWOHxJ2wzCBE2w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Sep 5, 2017 at 12:16 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Hm. I think it would be a fine idea to push this change into v10,
> so that all psql versions that have \if would have these variables.
> However, I'm less enthused about adding them to the 9.x branches.
> Given the lack of \if, I'm not seeing a use-case that would justify
> taking any compatibility risk for.
>
> Opinions anyone?

As I see it, the risks of back-patching are:

1. Different minor versions will have different behavior, and that
tends to create more problems than it solves.

2. There's a small probability that somebody's script could be relying
on these variables to be initially unset.

I think back-patching these changes into stable branches is a slippery
slope that we'd be best advised not to go down. I don't feel as
strongly about v10.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-09-05 16:37:26 pgsql: Support retaining data dirs on successful TAP tests
Previous Message Tom Lane 2017-09-05 16:16:12 Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version.

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-09-05 16:37:33 Re: A note about debugging TAP failures
Previous Message Tom Lane 2017-09-05 16:16:12 Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version.