Re: A note about debugging TAP failures

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, Craig Ringer <craig(dot)ringer(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: A note about debugging TAP failures
Date: 2017-09-05 16:37:33
Message-ID: 7ba71336-e958-eec2-f551-35df4715f9a4@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/25/17 11:00, Daniel Gustafsson wrote:
> Makes sense, assuming a “clean slate” to run on seems a reasonable assumption
> for the test and it makes for simpler code in PostgresNode. Updated the patch
> which now have static datadir names; retains on PG_TESTS_NOCLEAN or any kind of
> test failure; and allows for cleaning datadirs without having to use make clean
> (seems the wrong size hammer for that nail).

Committed. I had to make some changes in the pg_rewind tests. Those
make data directories with conflicting names, which did not work anymore
because the names are no longer random. Other than that this is pretty
nice. Thanks!

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-09-05 16:41:37 Re: JIT compiling expressions/deform + inlining prototype v2.0
Previous Message Robert Haas 2017-09-05 16:29:41 Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version.