Re: pg_basebackup, tablespace mapping and path canonicalization

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Ian Barwick <ian(at)2ndquadrant(dot)com>
Cc: pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup, tablespace mapping and path canonicalization
Date: 2015-02-06 13:25:42
Message-ID: CA+TgmoZjs+FAiHSy1LN8-ay6i0PxQQiCQhPoqio9V8T_oHJQ_g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 5, 2015 at 10:21 PM, Ian Barwick <ian(at)2ndquadrant(dot)com> wrote:
> I stumbled on what appears to be inconsistent handling of double slashes
> in tablespace paths when using pg_basebackup with the -T/--tablespace-mapping
> option:
>
> ibarwick:postgresql (master)$ mkdir /tmp//foo-old
[...]
> The attached patch adds the missing canonicalization; I can't see any
> reason not to do this. Thoughts?

Seems OK to me. Anyone think differently?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Wieck 2015-02-06 13:49:03 Re: Possible problem with pgcrypto
Previous Message Robert Haas 2015-02-06 13:20:41 Re: New CF app deployment