Re: pg_basebackup, tablespace mapping and path canonicalization

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Ian Barwick <ian(at)2ndquadrant(dot)com>, pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup, tablespace mapping and path canonicalization
Date: 2015-04-29 00:12:21
Message-ID: 20150429001221.GF31727@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 6, 2015 at 08:25:42AM -0500, Robert Haas wrote:
> On Thu, Feb 5, 2015 at 10:21 PM, Ian Barwick <ian(at)2ndquadrant(dot)com> wrote:
> > I stumbled on what appears to be inconsistent handling of double slashes
> > in tablespace paths when using pg_basebackup with the -T/--tablespace-mapping
> > option:
> >
> > ibarwick:postgresql (master)$ mkdir /tmp//foo-old
> [...]
> > The attached patch adds the missing canonicalization; I can't see any
> > reason not to do this. Thoughts?
>
> Seems OK to me. Anyone think differently?

Patch applied.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2015-04-29 00:25:52 Re: Allow SQL/plpgsql functions to accept record
Previous Message Fabrízio de Royes Mello 2015-04-28 23:28:28 Re: Can pg_dump make use of CURRENT/SESSION_USER