Re: MemoryContext reset/delete callbacks

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: MemoryContext reset/delete callbacks
Date: 2015-02-27 12:54:34
Message-ID: CA+TgmoZgdwa5jwmt+PnDKbRCVNDMQabFAsrfW7h3pOh5b79Jrg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 26, 2015 at 9:34 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
>> It's a bit sad to push AllocSetContextData onto four cachelines from the
>> current three... That stuff is hot. But I don't really see a way around
>> it right now. And it seems like it'd give us more amunition to improve
>> things than the small loss of speed it implies.
>
> Meh. I doubt it would make any difference, especially seeing that the
> struct isn't going to be aligned on any special boundary.

It might not make much difference, but I think avoiding unnecessary
padding space inside frequently-used data structures is probably a
smart idea.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-02-27 13:42:33 Re: Renaming MemoryContextResetAndDeleteChildren to MemoryContextReset
Previous Message Pavel Stehule 2015-02-27 12:38:18 Re: Providing catalog view to pg_hba.conf file - Patch submission