| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower(). |
| Date: | 2025-06-11 23:00:01 |
| Message-ID: | CA+TgmoZdaUptAgpkvMcBvsTny6V6TybuAOm1YHqjMJw9eFWOjg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Jun 11, 2025 at 6:15 PM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
> On Wed, 2025-06-11 at 16:07 -0400, Robert Haas wrote:
> > All 3 of these commits seem like things that could just as well have
> > been done after we branch.
>
> Yeah, I called out my mistake here:
>
> https://www.postgresql.org/message-id/60e8c6d0a6c08e67f15dbbe9e53df0119c710065.camel%40j-davis.com
>
> Nobody seemed terribly upset about it so I left them. But for the sake
> of ending any confusion I just reverted them. I will reapply them in a
> few weeks after the branch.
Sounds good. I don't know if those commits mattered or not; my main
intention was to make sure you weren't planning to keep going. But
short-term revert seems to minimize risk, so +1 from me.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-06-12 01:09:18 | pgsql: Revert support for improved tracking of nested queries |
| Previous Message | Peter Geoghegan | 2025-06-11 22:17:00 | pgsql: Revert "nbtree: Remove useless row compare arg." |