| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andreas Seltenreich <seltenreich(at)gmx(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [sqlsmith] Crash on GUC serialization |
| Date: | 2016-11-20 01:56:00 |
| Message-ID: | CA+TgmoZb_DYxGeKzS0KcxgjApVpS9=1WiL94tZgJSeKd-27zQg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Nov 19, 2016 at 12:31 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andreas Seltenreich <seltenreich(at)gmx(dot)de> writes:
>> sqlsmith just made a GUC that tricks the serialization code into
>> dereferencing a nullpointer. Here's a recipe:
>
> Thanks for the report! Looks like the serialization code has overlooked
> the fact that string-valued GUCs can be NULL. Surprising we didn't
> find that before ...
I had no idea that was possible. I think if we'd had a regression
test that set a GUC to such a value, I would have caught this in the
raft of bug fixes I submitted around December of last year, so maybe
we should add one. Why do we allow this, anyway?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-11-20 02:01:23 | Re: [sqlsmith] Crash on GUC serialization |
| Previous Message | Stephen Frost | 2016-11-20 00:04:05 | Re: [PATCH] pgpassfile connection option |