| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | comment for TwoPhaseGetOldestXidInCommit |
| Date: | 2025-10-07 16:25:45 |
| Message-ID: | CA+TgmoZYh_nw-2j_Fi9y6ZAvrpN+W1aSOFNM7Rus2Q-zTkCsQw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit and all,
I noticed today that TwoPhaseGetOldestXidInCommit has a header comment
where the same function is called TwoPhaseGetXidByLockingProc:
/*
* TwoPhaseGetXidByLockingProc
* Return the oldest transaction ID from prepared
transactions that are
* currently in the commit critical section.
*
* This function only considers transactions in the currently connected
* database. If no matching transactions are found, it returns
* InvalidTransactionId.
*/
TransactionId
TwoPhaseGetOldestXidInCommit(void)
This inconsistency should be corrected.
Thanks,
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-10-07 16:26:03 | Re: Add mode column to pg_stat_progress_vacuum |
| Previous Message | Tomas Vondra | 2025-10-07 16:24:06 | Re: Should we update the random_page_cost default value? |