Re: More work on SortSupport for text - strcoll() and strxfrm() caching

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: More work on SortSupport for text - strcoll() and strxfrm() caching
Date: 2015-10-14 23:09:59
Message-ID: CA+TgmoZXLMTqOZB7CUpVrtYWJPayMfUf6Aj723q1sB-_fifh7A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 14, 2015 at 7:05 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Mon, Oct 12, 2015 at 12:31 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
>> I'll consider a more comprehensive fix.
>
> I attach a revised fix that considers the problem of misinterpreting
> the contents of the buffers in both directions.

I wonder if it wouldn't be better to just add a separate Boolean
indicating exactly the thing we care about. This doesn't seem
particularly easy to understand and verify.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2015-10-14 23:11:15 Re: More work on SortSupport for text - strcoll() and strxfrm() caching
Previous Message Robert Haas 2015-10-14 23:06:46 Re: [PROPOSAL] DIAGNOSTICS <var> = SKIPPED_ROW_COUNT