Re: Observations in Parallel Append

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Observations in Parallel Append
Date: 2018-01-04 03:36:01
Message-ID: CA+TgmoZWzN6wUm0k-5+ros1RDJ+aV5qD8A+uyXH9GKNCwVpNkA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 2, 2018 at 11:11 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> Attached, please find the patch which fixes this issue (Thanks to
> Dilip for helping me in identifying the above case and fix). I have
> also modified the comment atop function
> choose_next_subplan_for_worker() as discussed above. The change to
> remove unnecessary inclusion of spin.h is still in a separate patch as
> posted above.

Here's a combined patch with some cosmetic changes which I will commit
if it looks OK to you.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
0001-Code-review-for-Parallel-Append.patch application/octet-stream 3.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2018-01-04 03:54:41 Re: Observations in Parallel Append
Previous Message Tom Lane 2018-01-04 02:09:24 Re: pgsql: Add parallel-aware hash joins.