| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Marti Raudsepp <marti(at)juffo(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: B-Tree support function number 3 (strxfrm() optimization) |
| Date: | 2015-01-23 16:50:13 |
| Message-ID: | CA+TgmoZRAo=9=Nz_hde-J7DzesL=H0PBLzRy6P8jOusr-RQz1w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 23, 2015 at 2:18 AM, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On 20 January 2015 at 17:10, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
>>
>> On Mon, Jan 19, 2015 at 7:47 PM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>
>> > With your patch applied, the failure with MSVC disappeared, but there
>> > is still a warning showing up:
>> > (ClCompile target) ->
>> > src\backend\lib\hyperloglog.c(73): warning C4334: '<<' : result of
>> > 32-bit shift implicitly converted to 64 bits (was 64-bit shift
>> > intended?
>>
>> That seems harmless. I suggest an explicit cast to "Size" here.
>
> This caught my eye too.
>
> I agree about casting to Size.
>
> Patch attached.
Thanks, committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-01-23 17:06:07 | Re: B-Tree support function number 3 (strxfrm() optimization) |
| Previous Message | Stephen Frost | 2015-01-23 15:57:53 | Re: WITH CHECK and Column-Level Privileges |