From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Himanshu Upadhyaya <upadhyaya(dot)himanshu(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
Subject: | Re: HOT chain validation in verify_heapam() |
Date: | 2023-03-23 13:42:16 |
Message-ID: | CA+TgmoZR-=172ZrLxorVHXYW1J9gruSgGqyORt2ivH=ALYYSXw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Mar 22, 2023 at 3:27 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> My animal mamba doesn't like this one bit.
>
> I suspect the reason is that it's big-endian (PPC) and the endianness
> hacking in the test is simply wrong:
>
> syswrite($file,
> pack("L", $ENDIANNESS eq 'little' ? 0x00010019 : 0x19000100))
> or BAIL_OUT("syswrite failed: $!");
>
> pack's L code should already be performing an endianness swap, so why
> are we doing another one in the argument?
(Apologies for having missed responding to this yesterday afternoon.)
Hmph. I didn't think very hard about that code and just assumed
Himanshu had tested it. I don't have convenient access to a Big-endian
test machine myself. Are you able to check whether using 0x00010019
unconditionally works?
I think part of the reason that I thought this looked OK was because
there are other places in this test case that do stuff differently
based on endian-ness, but now that you mention it, I realize that
stuff has to do with the varlena representation, which is
endian-dependent in a way that the ItemIdData representation is not.
--
Robert Haas
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2023-03-23 13:45:48 | Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL |
Previous Message | vignesh C | 2023-03-23 13:36:32 | Re: Support logical replication of DDLs |