Re: [sqlsmith] crashes in RestoreSnapshot on hot standby

On Fri, Jul 1, 2016 at 1:41 AM, Andreas Seltenreich <seltenreich(at)gmx(dot)de> wrote:
> Amit Kapila writes:
>> On Fri, Jul 1, 2016 at 9:38 AM, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>>> Or maybe just like this?
>>>
>>> - snapshot->subxip = snapshot->xip + serialized_snapshot->xcnt;
>>> + snapshot->subxip = ((TransactionId *) (snapshot + 1)) +
>>> + serialized_snapshot->xcnt;
>>>
>>
>> This way it looks better to me. Thanks for the patch.
>
> I no longer see these crashes when testing with the patch applied.

Committed and back-patched to 9.5 where this code was added. Thanks
to all for the report, patch, review, and testing.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company