Re: Emit extra debug message when executing extension script.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Emit extra debug message when executing extension script.
Date: 2022-07-05 18:43:33
Message-ID: CA+TgmoZDeNN4F89R1RFZU0eaROL4yGYTpdJ3B+cdirYoYmKc2A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 4, 2022 at 5:27 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> On 2022-Jun-29, Robert Haas wrote:
> > On Wed, Jun 29, 2022 at 9:26 AM Peter Eisentraut
> > <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> > > On 28.06.22 21:10, Jeff Davis wrote:
> > > > + ereport(DEBUG1, errmsg("executing extension script: %s", filename));
> > >
> > > This should either be elog or use errmsg_internal.
> >
> > Why?
>
> The reason is that errmsg() marks the message for translation, and we
> don't want to burden translators with messages that are of little
> interest to most users. Using either elog() or errmsg_internal()
> avoids that.

Yeah, I'm aware of that in general, but I'm not quite clear on how we
decide that. Do we take the view that all debug-level messages need
not be translated?

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message James Coleman 2022-07-05 18:46:13 Re: pg_rewind: warn when checkpoint hasn't happened after promotion
Previous Message Robert Haas 2022-07-05 18:42:03 Re: PSA: Autoconf has risen from the dead