| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Emit extra debug message when executing extension script. |
| Date: | 2022-07-04 09:27:53 |
| Message-ID: | 20220704092753.ancsnxqg2gltgal4@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-Jun-29, Robert Haas wrote:
> On Wed, Jun 29, 2022 at 9:26 AM Peter Eisentraut
> <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> > On 28.06.22 21:10, Jeff Davis wrote:
> > > + ereport(DEBUG1, errmsg("executing extension script: %s", filename));
> >
> > This should either be elog or use errmsg_internal.
>
> Why?
The reason is that errmsg() marks the message for translation, and we
don't want to burden translators with messages that are of little
interest to most users. Using either elog() or errmsg_internal()
avoids that.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"El sudor es la mejor cura para un pensamiento enfermo" (Bardia)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ken Kato | 2022-07-04 09:29:08 | Add last_vacuum_index_scans in pg_stat_all_tables |
| Previous Message | Alvaro Herrera | 2022-07-04 08:49:33 | Re: Using PQexecQuery in pipeline mode produces unexpected Close messages |