| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: GinPageIs* don't actually return a boolean |
| Date: | 2016-02-11 14:51:26 |
| Message-ID: | CA+TgmoZC4K=f6NR2-X7nu69hQMMU4U5T4Rq6VSFgg9+S8n6Eag@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 11, 2016 at 9:15 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2016-02-11 08:50:41 -0500, Robert Haas wrote:
>> Are we thinking to back-patch this? I would be disinclined to
>> back-patch widespread changes like this. If there's a specific
>> instance related to Gin where this is causing a tangible problem, we
>> could back-patch just that part, with a clear description of that
>> problem. Otherwise, I think this should be master-only.
>
> I'm not sure. It's pretty darn nasty that right now we fail in some
> places in the code if stdbool.h is included previously. That's probably
> going to become more and more common. On the other hand it's invasive,
> as you say. Partially patching things doesn't seem like a really viable
> approach to me, bugs caused by this are hard to find/trigger.
I have never been quite clear on what you think is going to cause
stdbool.h inclusions to become more common.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-02-11 14:53:36 | Re: Patch: fix lock contention for HASHHDR.mutex |
| Previous Message | Masahiko Sawada | 2016-02-11 14:49:06 | Re: Freeze avoidance of very large table. |