| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: blkreftable.c needs more sanity checks |
| Date: | 2026-07-15 15:36:46 |
| Message-ID: | CA+TgmoZ6rgU8KtCKEhcajMzc0t+BvT7L2JqdhiUpDTejd9c4bw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 14, 2026 at 7:31 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> A more likely scenario is that you are hacking in this code and have made silly
> errors. It mostly seemed consistent with how the forknum error is reported,
> but is not important.
Upon reflection, it occurred to me that I would probably rather have
the chunk offset than the chunk size if this ever trips, so I added
both to the error message. Here's v2.
> No disagreement there, which is why I tried to get it reviewed quickly so it
> can be applied and forgotten about and we can move on to more important
> matters.
Thanks for reviewing.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-additional-sanity-checks-when-reading-a-blkre.patch | application/octet-stream | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-07-15 15:36:52 | Re: SQL:2011 Application Time Update & Delete |
| Previous Message | Nathan Bossart | 2026-07-15 15:35:09 | Re: Enforce INSERT RLS checks for FOR PORTION OF leftovers? |