Re: blkreftable.c needs more sanity checks

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: blkreftable.c needs more sanity checks
Date: 2026-07-15 15:40:22
Message-ID: B28E7F53-0663-447E-8547-F5811F979E8A@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 15 Jul 2026, at 17:36, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Tue, Jul 14, 2026 at 7:31 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> A more likely scenario is that you are hacking in this code and have made silly
>> errors. It mostly seemed consistent with how the forknum error is reported,
>> but is not important.
>
> Upon reflection, it occurred to me that I would probably rather have
> the chunk offset than the chunk size if this ever trips, so I added
> both to the error message. Here's v2.

LGTM, +1 on applying.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2026-07-15 15:40:33 Re: implement CAST(expr AS type FORMAT 'template')
Previous Message Nathan Bossart 2026-07-15 15:36:52 Re: SQL:2011 Application Time Update & Delete