Re: Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement
Date: 2011-11-17 23:45:44
Message-ID: CA+TgmoYxuyCM-POHSMfLq2qnZ8xerMNxOiGTzr+nBQh6krTDHA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 17, 2011 at 5:29 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Thu, Nov 17, 2011 at 4:26 PM, Alvaro Herrera
>> <alvherre(at)commandprompt(dot)com> wrote:
>>> So the buildfarm broke due to this change, because citext does
>
>> Thanks for fixing it.  Should we revert the original change?
>
> I still think it's reasonable to remove the extra downcasing step,
> but we'll have to document it as a change.  For instance, spelling
> C as either "C" or 'C' would work differently now.  The fact that
> the former is downcased seems quite surprising to me, so I don't
> think anybody would say that this isn't a better definition, but
> undoubtedly it could force people to change their source files.

So, should we add a note to all the LANGUAGE command pages in the
manual? Or just include this in the release notes?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Royce Ausburn 2011-11-18 00:05:46 Re: [PATCH] Unremovable tuple monitoring
Previous Message Robert Haas 2011-11-17 23:44:34 Re: [PATCH] Unremovable tuple monitoring