| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement |
| Date: | 2011-11-17 22:29:29 |
| Message-ID: | 9500.1321568969@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Nov 17, 2011 at 4:26 PM, Alvaro Herrera
> <alvherre(at)commandprompt(dot)com> wrote:
>> So the buildfarm broke due to this change, because citext does
> Thanks for fixing it. Should we revert the original change?
I still think it's reasonable to remove the extra downcasing step,
but we'll have to document it as a change. For instance, spelling
C as either "C" or 'C' would work differently now. The fact that
the former is downcased seems quite surprising to me, so I don't
think anybody would say that this isn't a better definition, but
undoubtedly it could force people to change their source files.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Kupershmidt | 2011-11-17 22:39:40 | Re: psql + libedit command history truncation (was: psql history vs. dearmor (pgcrypto)) |
| Previous Message | Rudyar | 2011-11-17 22:19:03 | Re: how to get tuple |