Re: Fixing order of resowner cleanup in 12, for Windows

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fixing order of resowner cleanup in 12, for Windows
Date: 2019-05-06 18:08:18
Message-ID: CA+TgmoYoBp0u1n41nkaHYeL_ROyTZa9yksqZkzGKay66=M03jA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 6, 2019 at 1:58 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > Right. That's why I favor applying the change to move DSM cleanup to
> > the end for now, and seeing how that goes. It could be that we'll
> > eventually discover that doing it before all of the AtEOXact_BLAH
> > functions have had a short at doing their thing is still too early,
> > but the only concrete problem that we know about right now can be
> > solved by this much-less-invasive change.
>
> But Amit's results say that this *doesn't* fix the problem that we know
> about. I suspect the reason is exactly that we need to run AtEOXact_Files
> or the like before closing DSM. But we should get some Windows developer
> to trace through this and identify the cause for-sure before we go
> designing an invasive fix.

Huh, OK.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Paul Jungwirth 2019-05-06 18:17:46 Re: range_agg
Previous Message Robert Haas 2019-05-06 18:03:13 Re: Attempt to consolidate reading of XLOG page