| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, Andreas Karlsson <andreas(at)proxel(dot)se>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patches that don't apply or don't compile: 2017-09-12 |
| Date: | 2017-09-14 20:13:46 |
| Message-ID: | CA+TgmoYi60_yy5wqEygn13wnxu6vrFbbpDp4X51PD3cz5BUoGg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 13, 2017 at 5:18 AM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Thinking further, I think changing patch status automatically may never
> be a good idea; there's always going to be some amount of common sense
> applied beforehand (such as if a conflict is just an Oid catalog
> collision, or a typo fix in a recent commit, etc). Such conflicts will
> always raise errors with a tool, but would never cause a (decent) human
> being from changing the patch status to WoA.
Well it would perhaps be fine if sending an updated patch bounced it
right back to Needs Review. But if things are only being auto-flipped
in one direction that's going to get tedious.
Or one could imagine having the CF app show the CI status alongside
the existing status column.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-09-14 20:15:39 | Re: [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur |
| Previous Message | Robert Haas | 2017-09-14 20:08:08 | Re: postgres_fdw super user checks |