Re: ATT_FOREIGN_TABLE and ATWrongRelkindError()

On Mon, Oct 26, 2015 at 3:12 AM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> On 2015/10/23 19:02, Amit Langote wrote:
>> On 2015/10/23 18:51, Etsuro Fujita wrote:
>>>
>>> This is really really nitpicking, but I noticed that there is an implicit
>>> rule concerning the message format in ATWrongRelkindError; if more than
>>> two objects are present, the message is "\"%s\" is not a foo, bar, or
>>> baz". ("or" is preceded by a comma!) So, would it be better that the
>>> former is "\"%s\" is not a table, view, or foreign table"?
>>
>> Oops! Yeah, I missed the comma there. That seems like a generally
>> preferred punctuation rule (the comma before conjunction(s) I mean).
>
> Here is a patch rectifying that mistake.

Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company