| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ATT_FOREIGN_TABLE and ATWrongRelkindError() |
| Date: | 2015-10-26 02:12:53 |
| Message-ID: | 562D8C25.1070109@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015/10/23 19:02, Amit Langote wrote:
> On 2015/10/23 18:51, Etsuro Fujita wrote:
>>
>> This is really really nitpicking, but I noticed that there is an implicit
>> rule concerning the message format in ATWrongRelkindError; if more than
>> two objects are present, the message is "\"%s\" is not a foo, bar, or
>> baz". ("or" is preceded by a comma!) So, would it be better that the
>> former is "\"%s\" is not a table, view, or foreign table"?
>
> Oops! Yeah, I missed the comma there. That seems like a generally
> preferred punctuation rule (the comma before conjunction(s) I mean).
Here is a patch rectifying that mistake.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| add-comma-before-or.patch | text/x-diff | 636 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2015-10-26 02:24:29 | Re: pgbench gaussian/exponential docs improvements |
| Previous Message | Michael Paquier | 2015-10-26 02:12:03 | Re: questions about PG update performance |