| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Michael Banck <michael(dot)banck(at)credativ(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Verify Checksums during Basebackups |
| Date: | 2018-03-02 18:04:21 |
| Message-ID: | CA+TgmoYezf55EFUAQZ-zHugOcmCaTMs+znmp1sHCw=xm=eSjsA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 2, 2018 at 6:23 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Another quick note -- we need to assert that the size of the buffer is
> actually divisible by BLCKSZ. I don't think it's a common scenario, but it
> could break badly if somebody changes BLCKSZ. Either that or perhaps just
> change the TARSENDSIZE to be a multiple of BLCKSZ.
I think that this patch needs to support all block sizes that are
otherwise supported -- failing an assertion doesn't seem like a
reasonable option, unless it only happens for block sizes we don't
support anyway.
+1 for the feature in general. I think this would help a lot of peple.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-03-02 18:20:05 | Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly |
| Previous Message | Fujii Masao | 2018-03-02 18:04:18 | Re: [HACKERS] Creating backup history files for backups taken from standbys |