Re: Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement
Date: 2011-11-17 19:25:03
Message-ID: CA+TgmoYehdxYpzi+eQn3zoC+8ThP9bBK8Fm=NdJsR62L=w71Kg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 17, 2011 at 1:00 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> It also eliminates the NOTICE when removing a built-in
>> function, which I think is OK because you don't actually get that far:
>
> There are paths that can reach that notice --- I think what you have to
> do is create a new function that references a built-in one.  But why
> we bother to warn for that isn't clear to me.
>
>> - For some reason, we have code that causes procedural language names
>> to be downcased before use.
>
> I think this is a hangover from the fact that CREATE FUNCTION's LANGUAGE
> clause used to insist on the language name being a string literal, and
> of course the lexer didn't case-fold it then.  That's been deprecated
> for long enough that we probably don't need to have the extra case-fold
> step anymore.

OK, great.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2011-11-17 20:18:49 Re: Core Extensions relocation
Previous Message Jeff Davis 2011-11-17 18:18:47 Re: declarations of range-vs-element <@ and @>