Re: Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement
Date: 2011-11-17 21:26:09
Message-ID: 1321565111-sup-4853@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Excerpts from Robert Haas's message of jue nov 17 16:25:03 -0300 2011:
> On Thu, Nov 17, 2011 at 1:00 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Robert Haas <robertmhaas(at)gmail(dot)com> writes:

> >> - For some reason, we have code that causes procedural language names
> >> to be downcased before use.
> >
> > I think this is a hangover from the fact that CREATE FUNCTION's LANGUAGE
> > clause used to insist on the language name being a string literal, and
> > of course the lexer didn't case-fold it then.  That's been deprecated
> > for long enough that we probably don't need to have the extra case-fold
> > step anymore.
>
> OK, great.

So the buildfarm broke due to this change, because citext does

--
-- Aggregates.
--

CREATE FUNCTION citext_smaller(citext, citext)
RETURNS citext
AS 'MODULE_PATHNAME'
LANGUAGE 'C' IMMUTABLE STRICT;

CREATE FUNCTION citext_larger(citext, citext)
RETURNS citext
AS 'MODULE_PATHNAME'
LANGUAGE 'C' IMMUTABLE STRICT;

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-11-17 22:10:47 Re: Are range_before and range_after commutator operators?
Previous Message Alvaro Herrera 2011-11-17 21:12:54 Re: RangeVarGetRelid()