Re: pg_basebackup is taking backup of extra files inside a tablespace directory

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Hari Babu <haribabu(dot)kommi(at)huawei(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup is taking backup of extra files inside a tablespace directory
Date: 2012-11-30 19:30:24
Message-ID: CA+TgmoYdYeXuFvTasCqvZuecXaYi6-B=D5TNxROzDS3UntGbRQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 28, 2012 at 1:55 AM, Hari Babu <haribabu(dot)kommi(at)huawei(dot)com> wrote:
> I think backup should be done only files and folders present inside
> '/opt/tblspc/PG_*' directory (TABLESPACE_VERSION_DIRECTORY).
> Not all the files and folders in side '/opt/tblspc.' directory.

I think I agree. The current behavior would have made sense in older
releases of PG where we plopped down our stuff right inside the
tablespace directory, but now that everything is being shoved in a
subdirectory I don't see a reason to copy anything other than that
subdirectory. Of course it's probably bad style to have anything
that's not related to PG in there, but given that the whole point of
this change was to allow different PG versions to create tablespaces
on the same directory at the same time, we can hardly say that this is
a case that should never arise in real life.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-11-30 19:35:37 Re: Hot Standby Feedback should default to on in 9.3+
Previous Message Simon Riggs 2012-11-30 19:26:30 Re: Hot Standby Feedback should default to on in 9.3+