Re: [COMMITTERS] pgsql: Improve pg_dump regression tests and code coverage

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Improve pg_dump regression tests and code coverage
Date: 2017-03-20 14:24:22
Message-ID: CA+TgmoYXT07F04W=9KMNR8uU_7btOEmeS0Are-PKipSS-YhrRA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Mar 20, 2017 at 9:30 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> While I certainly agree with that when it comes to new features, changes
> in work-flow, bug fixes and other things, I'm really not sure that
> requiring posting to the list and waiting for responses every time
> someone wants to add some regression tests is a useful way to spend
> time.

I'm not sure that arguing about whether patches are supposed to have
review and discussion before they're committed is a useful way to
spend time either. I think most people here accept that as a
requirement. If you really don't understand the committing a
never-before-posted 3000+-line patch out of the blue three weeks after
the patch submission deadline is out of process, maybe you shouldn't
be committing things at all. I'm glad that you are working on fixing
pg_dump bugs and improving test coverage, but my gladness about that
does not extend to thinking that the processes which other people
follow for their work should be waived for yours. Sorry.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2017-03-20 14:35:15 Re: [COMMITTERS] pgsql: Improve pg_dump regression tests and code coverage
Previous Message Tom Lane 2017-03-20 14:13:15 Re: Re: [COMMITTERS] pgsql: Add TAP tests for password-based authentication methods.

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2017-03-20 14:25:32 Re: Inadequate traces in TAP tests
Previous Message Heikki Linnakangas 2017-03-20 14:19:42 Re: [PATCH] Incremental sort