Re: Re: [COMMITTERS] pgsql: Add TAP tests for password-based authentication methods.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Add TAP tests for password-based authentication methods.
Date: 2017-03-20 14:13:15
Message-ID: 30395.1490019195@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> On 03/20/2017 02:32 AM, Peter Eisentraut wrote:
>> This is missing an entry for tmp_check/ in .gitignore. But maybe we can
>> do that globally instead of repeating it in every directory?

> If we could also handle results and log globally, that would be nice.
> But IMHO those names are too generic to put to a global .gitignore. We
> could rename them, but this starts to feel like more trouble than it's
> worth. I'll just go and create a .gitignore for /tmp_check/ to
> src/test/authentication.

FWIW, that was my thought about it as well. Handling tmp_check
differently from those other two just seems confusing.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-03-20 14:24:22 Re: [COMMITTERS] pgsql: Improve pg_dump regression tests and code coverage
Previous Message Stephen Frost 2017-03-20 13:30:46 Re: [COMMITTERS] pgsql: Improve pg_dump regression tests and code coverage

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2017-03-20 14:18:07 Re: Inadequate traces in TAP tests
Previous Message Tom Lane 2017-03-20 14:08:38 Re: Inadequate traces in TAP tests