Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

On Wed, Oct 12, 2016 at 8:18 AM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 10/4/16 11:29 AM, Tom Lane wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> Apparently, 'make world' does not build worker_spi. I thought 'make
>>> world' was supposed to build everything?
>>
>> You'd have thunk, yeah. It looks like the issue is that src/Makefile
>> is selective about recursing into certain subdirectories of test/,
>> but mostly not test/ itself. src/test/Makefile naively believes it's
>> in charge, though. Probably that logic ought to get shoved down one
>> level, and then adjusted so that src/test/modules gets built by "all".
>> Or else teach top-level "make world" to do "make all" in src/test/,
>> but that seems like it's just doubling down on confusing interconnections.
>
> We generally don't build test code during make world.
>
> The reason src/Makefile does that is probably because pg_regress is part
> of the installation.
>
> So this looks more or less correct to me.

But it's annoying to push code and have it break the buildfarm when
you already did 'make world' and 'make check-world'. What target
should I be using?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company