| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: Fix for pg_upgrade status display |
| Date: | 2012-12-06 17:43:53 |
| Message-ID: | CA+TgmoYQ61GXAkOOK9tLw1Fph9kUo9ULAD0WoO7Mxe6Gyvz=WQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 5, 2012 at 10:04 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Pg_upgrade displays file names during copy and database names during
> dump/restore. Andrew Dunstan identified three bugs:
>
> * long file names were being truncated to 60 _leading_ characters, which
> often do not change for long file names
>
> * file names were truncated to 60 characters in log files
>
> * carriage returns were being output to log files
>
> The attached patch fixes these --- it prints 60 _trailing_ characters to
> the status display, and full path names without carriage returns to log
> files.
This might be a dumb question, but why limit it to 60 characters at
all instead of, say, MAXPGPATH?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-12-06 17:45:26 | Re: autovacuum truncate exclusive lock round two |
| Previous Message | Tom Lane | 2012-12-06 17:33:23 | Re: Serious problem: media recovery fails after system or PostgreSQL crash |