Re: Fix for pg_upgrade status display

Robert Haas escribió:
> On Wed, Dec 5, 2012 at 10:04 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Pg_upgrade displays file names during copy and database names during
> > dump/restore. Andrew Dunstan identified three bugs:
> >
> > * long file names were being truncated to 60 _leading_ characters, which
> > often do not change for long file names
> >
> > * file names were truncated to 60 characters in log files
> >
> > * carriage returns were being output to log files
> >
> > The attached patch fixes these --- it prints 60 _trailing_ characters to
> > the status display, and full path names without carriage returns to log
> > files.
>
> This might be a dumb question, but why limit it to 60 characters at
> all instead of, say, MAXPGPATH?

I think this should be keyed off the terminal width, actually, no? The
whole point of this is to overwrite the same line over and over, right?

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services